Slay the dragon #57
Merged
Slay the dragon #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #57 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 296 296
=========================================
Hits 296 296 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cgarling
reviewed
May 8, 2025
| (l::law)(wavelength::U.Quantity) = l(U.ustrip(U.u"Å", wavelength)) * U.u"mag" | ||
| end | ||
| # generate unitful support | ||
| (l::ExtinctionLaw)(wavelength::U.Quantity) = l(U.ustrip(U.u"Å", wavelength)) * U.u"mag" |
Member
There was a problem hiding this comment.
While we're editing this I wonder if it makes sense to check dimensions here by dispatching as (l::ExtinctionLaw)(wavelength::U.Length) because wavelengths only make sense as lengths.
Member
Author
There was a problem hiding this comment.
Agreed. Making the switch seems to make the error message a bit more opaque though:
With (l::ExtinctionLaw)(wavelength::U.Quantity)
julia> CCM89()(1e4/5)
2.8425264357868345
julia> CCM89()(2000u"Å")
2.8425264357868345 mag
julia> CCM89()(2000u"kg")
ERROR: DimensionError: Å and kg are not dimensionally compatible.
Stacktrace:
[1] #s103#141
@ ~/.julia/packages/Unitful/nwwOk/src/conversion.jl:28 [inlined]
[2] var"#s103#141"(::Any, s::Any, t::Any)
@ Unitful ./none:0
[3] (::Core.GeneratedFunctionStub)(::UInt64, ::LineNumberNode, ::Any, ::Vararg{Any})
@ Core ./boot.jl:707
[4] uconvert(a::Unitful.FreeUnits{(Å,), 𝐋, nothing}, x::Quantity{Int64, 𝐌, Unitful.FreeUnits{(kg,), 𝐌, nothing}})
@ Unitful ~/.julia/packages/Unitful/nwwOk/src/conversion.jl:93
[5] ustrip
@ ~/.julia/packages/Unitful/nwwOk/src/utils.jl:37 [inlined]
[6] (::CCM89)(wavelength::Quantity{Int64, 𝐌, Unitful.FreeUnits{(kg,), 𝐌, nothing}})
@ DustExtinction ~/projects/DustExtinction.jl/src/DustExtinction.jl:167
[7] top-level scope
@ REPL[30]:1With (l::ExtinctionLaw)(wavelength::U.Length)
julia> CCM89()(1e4/5)
2.8425264357868345
julia> CCM89()(2000u"Å")
2.8425264357868345 mag
julia> CCM89()(2000u"kg")
ERROR: MethodError: no method matching (::CCM89)(::Quantity{Int64, 𝐌, Unitful.FreeUnits{(kg,), 𝐌, nothing}})
The object of type `CCM89` exists, but no method is defined for this combination of argument types when trying to treat it as a callable object.
Closest candidates are:
(::CCM89)(::T) where T<:Real
@ DustExtinction ~/projects/DustExtinction.jl/src/color_laws/ccm89.jl:25
(::DustExtinction.ExtinctionLaw)(::Union{Quantity{T, 𝐋, U}, Level{L, S, Quantity{T, 𝐋, U}} where {L, S}} where {T, U})
@ DustExtinction ~/projects/DustExtinction.jl/src/DustExtinction.jl:167
Stacktrace:
[1] top-level scope
@ REPL[25]:1
Member
There was a problem hiding this comment.
Right, I guess the type conversion ends up requiring a length anyway, nbd
Member
|
Looks good to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we are past supporting pre-v1.3 versions of Julia, are we ready to put this legendary comment to rest?